fix: invalid response type on post request #15609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrod
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Approving, but: @AlanCoding might know if there's a more DRF-ey way to do this with @api_view or the like. But this looks simple enough to me and fixes the fatal.
|
Actually: It might be nice to have a regression test for this (just mocking out is_proxied_request and calling the endpoint) |
|
@relrod I'm working on a test for this 👍 |
djyasin
approved these changes
Nov 11, 2024
|
Would add tests for this one, feels self-contained enough 🙏 |
|
@djyasin @PabloHiro thanks, I'll add the tests in this PR |
|
relrod
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix the 500 response when sending an unauthenticated
POSTrequest to/api/controller/login. Using a djangoJsonResponseavoids the error.Verified by running this on OpenShift with Gateway.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION