Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed oAuth methods from collection docs. #15606

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Removed oAuth methods from collection docs. #15606

merged 2 commits into from
Nov 7, 2024

Conversation

tvo318
Copy link
Member

@tvo318 tvo318 commented Oct 28, 2024

SUMMARY

This PR removes no-longer applicable OAuth methods of authentication from the collection docs, including mentions of tokens, references in tests, etc.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • Collection
  • Docs
AWX VERSION

latest

@github-actions github-actions bot added the component:awx_collection issues related to the collection for controlling AWX label Oct 28, 2024
@tvo318 tvo318 requested a review from hakbailey October 28, 2024 21:52
@tvo318
Copy link
Member Author

tvo318 commented Oct 28, 2024

@gravesm - I can't seem to add you as a reviewer, but can you take a look and provide feedback as well? Thanks!

gravesm
gravesm reviewed Oct 29, 2024
View reviewed changes
awx_collection/plugins/doc_fragments/auth.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The collection sanity tests are going to continue to fail until we have actually removed the oauth token options from the modules. My suggestion would be to remove the changes to the doc fragments from this PR, and they can just be done as part of the PR to remove the options. Alternatively, we can wait that work lands before continuing with this one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and re-instated the changes from the doc fragments.

@tvo318 tvo318 requested a review from gravesm October 29, 2024 21:59
@jjwatt jjwatt requested a review from hakbailey October 31, 2024 14:38
@jjwatt
Copy link
Contributor

jjwatt commented Nov 5, 2024

@TheRealHaoLiu PTAL

@TheRealHaoLiu TheRealHaoLiu enabled auto-merge (squash) November 7, 2024 15:45
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TheRealHaoLiu TheRealHaoLiu merged commit aa162c6 into ansible:devel Nov 7, 2024
21 of 25 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
@tvo318 @djyasin
Removed oAuth methods from collection docs. (ansible#15606)
9be844e 
* Removed oAuth methods from collection docs.
@tvo318 tvo318 deleted the removeOAuth-collections branch November 14, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealHaoLiu TheRealHaoLiu TheRealHaoLiu approved these changes

@hakbailey hakbailey hakbailey approved these changes

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tvo318 @jjwatt @gravesm @hakbailey @TheRealHaoLiu