Fix environment-specific rough edges of logging setup #15193

AlanCoding · 2024-05-15T15:41:42Z

SUMMARY

Two separate random things here. Firstly, I have no expectation that this would work:

import logging

logging.handlers.SysLogHandler

You didn't import the logging.handlers module... so why should python have loaded that module? You get SysLogHandler if you load that module. Newer versions of python will fail with this syntax, but there's no reason we shouldn't do it generally.

Next, the blanket ImportError will (logically) often error on not having colorama or whatever. But what happens then? It passes. But... if you were in this block that means that the COLOR_LOGS is True in settings. If that setting is true, that means you're using color logs, which means that the class ColorHandler will be referenced in the logging dict config. But the pass means that it won't be defined. So the error you'll get is just simply that it can't import awx.main.utils.handlers.ColorHandler