Ability to use updater script to pin dev requirements #14644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
AlanCoding
commented
Nov 9, 2023
| @@ -9,7 +9,6 @@ black | |||
| pytest!=7.0.0 | |||
| pytest-cov | |||
| pytest-django | |||
| pytest-pythonpath | |||
There was a problem hiding this comment.
This library requires an old version of pytest which is, of course, conflicting with other libraries here. I guess it just ignored the conflict up until this point. If you actually go to the project, it basically says it's old and don't use it anymore. This won't work with the conflict, and it seems we didn't need this either.
AlanCoding
requested review from
chrismeyersfsu,
rooftopcellist and
jbradberry
jbradberry
reviewed
Jan 29, 2024
jbradberry
approved these changes
Jan 29, 2024
|
@TheRealHaoLiu had the idea of pinning the black version when we do a tower release. I like that. Keep awx devel unpinned so we hit new versions of black and deal with the changes. Pin old releases to black version at that time. This change unlocks that ability. |
chrismeyersfsu
approved these changes
Feb 6, 2024
AlanCoding
force-pushed
the
dev_requirements
branch
from
0db1aa6
to
0d51aa5
Compare
|
I re-tested and it works so I'll go ahead and merge. |
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
* Add a dev option for updater script to pin CI reqs * Avoid removing git links for dev requirements * Add dev to primary options * Fix up sanitize git switch
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
* Add a dev option for updater script to pin CI reqs * Avoid removing git links for dev requirements * Add dev to primary options * Fix up sanitize git switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Don't plan to use this here, but it's good to have for forks, so they won't get surprised by updates to these libraries.
ISSUE TYPE
COMPONENT NAME