Fix: login rerouting only works on the user's current tab (Pull request: #14399) #14605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sasa993
force-pushed
the
devel
branch
2 times, most recently
from
4714ebb
to
f0ab750
Compare
|
Has anyone had a chance to review this PR? |
|
Hi @Sasa993! Thank you so much for this contribution. Rest assured, we certainly will review your PR! We are just a bit slower than normal due to the holidays. We will get back to you soon! |
auto-merge was automatically disabled
February 15, 2024 13:56
Head branch was pushed to by a user without write access
|
@dmzoneill I fixed the ui-lint error. I think it can be merged now :) thanks! |
…#14399) Signed-off-by: Sasa Jovicic <[email protected]>
dmzoneill
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes a bug from this pull request.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
Before this fix, rerouting after user's authentication works only in the browser's tab that user is currently at.
If you open a new tab (or click on the link), fix from PR does not work.