Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce mutually exclusive options in credential module of the collection #14363

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Enforce mutually exclusive options in credential module of the collection #14363

merged 2 commits into from
Aug 23, 2023

Conversation

djdanielsson
Copy link
Contributor

@djdanielsson djdanielsson commented Aug 21, 2023 •
edited
Loading

SUMMARY

updating code to enforce mutually exclusive options more clearly in the credential module

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Collection
AWX VERSION
NA

@github-actions github-actions bot added component:awx_collection issues related to the collection for controlling AWX community labels Aug 21, 2023
sean-m-sullivan
sean-m-sullivan approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, both the code and notes, as reread this and to experienced users its just known, but never spelled out.

@AlanCoding AlanCoding changed the title updating code to enforce mutually exclusive options more clearly Enforce mutually exclusive options in credential module of the collection Aug 22, 2023
@rebeccahhh rebeccahhh added the needs_developer has had some work done but needs some ushering forward. label Aug 23, 2023
@rebeccahhh
Copy link
Member

lgtm, merging

@rebeccahhh rebeccahhh merged commit f6dd3cb into ansible:devel Aug 23, 2023
16 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
@djdanielsson @djyasin
Enforce mutually exclusive options in credential module of the collec…
3592e6e 
…tion (ansible#14363)
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
@djdanielsson @djyasin
Enforce mutually exclusive options in credential module of the collec…
b063a98 
…tion (ansible#14363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-m-sullivan sean-m-sullivan sean-m-sullivan approved these changes

@AlanCoding AlanCoding AlanCoding approved these changes

Assignees
No one assigned
Labels
community component:awx_collection issues related to the collection for controlling AWX needs_developer has had some work done but needs some ushering forward.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djdanielsson @rebeccahhh @AlanCoding @sean-m-sullivan