chore: added aggregate labels to ClusterRoles with kustomize #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We want to add user-facing roles to awx ClusterRole resources. This would allow our users to automatically view/manage these resources without an admin needing to craft custom role bindings.
Cert-Manager Example
Another operator that does this is cert-manager. Here is an issue from cert-manager where they handle a similar problem. They only create the aggregate ClusterRoles if the global.rbac.aggregateClusterRoles value is set to true in their values.yaml.
ISSUE TYPE
ADDITIONAL INFORMATION
This PR will certainly change current state behavior, possibly granting new permissions to people who update as these ClusterRoles previously had to be specifically installed. An alternative to this would be providing a kustomize patch file which can add these roles, so that people can opt-in instead of automatically being granted these permissions.