Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate collection deprecation changelog entries from metadata #457

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

felixfontein
Copy link
Contributor

Use ansible-community/antsibull-build#623 to automatically generate collection deprecation changelog entries from metadata.

@mariolenz
Copy link
Collaborator

I should say the output looks OK.

BTW do you want to merge this eventually or is this only meant as an example how it would look like?

@felixfontein
Copy link
Contributor Author

BTW do you want to merge this eventually or is this only meant as an example how it would look like?

I'd merge it together with ansible-community/antsibull-build#623, so that re-generating the changelogs (for example when the next release happens) doesn't result in changes of older entries.

@felixfontein
Copy link
Contributor Author

I updated the PR to the latest version of ansible-community/antsibull-build#623 and this repo.

@felixfontein
Copy link
Contributor Author

#459 will allow to also generate the removal changelog fragments automatically.

10/CHANGELOG-v10.md Outdated Show resolved Hide resolved
10/CHANGELOG-v10.md Outdated Show resolved Hide resolved
@felixfontein felixfontein force-pushed the changelog branch 2 times, most recently from 465b1a4 to f2f12e6 Compare October 3, 2024 13:02
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot of changes so it's hard to be sure, but I should say this LGTM now.

@felixfontein
Copy link
Contributor Author

I'd like to regenerate the changelog (and docsite) once more once #464 is merged, to see whether the markup formatting works.

@mariolenz
Copy link
Collaborator

Makes sense. Better test this and make make sure.

@felixfontein
Copy link
Contributor Author

(With the latest changes from ansible-community/antsibull-build#623 and with #464 merged, the generated changelogs will look exactly as they already do. All changes only affect entries in versions not yet released. See ansible-community/antsibull-build#623 (comment) for how the result looks like for 11.0.0a2.)

@felixfontein felixfontein changed the title [WIP] Automatically generate collection deprecation changelog entries from metadata Automatically generate collection deprecation changelog entries from metadata Oct 6, 2024
@felixfontein
Copy link
Contributor Author

I'll keep this marked as draft until ansible-community/antsibull-build#623 has been merged, then I will merge the latest version of this.

@felixfontein
Copy link
Contributor Author

The CI failure is unrelated.

@felixfontein felixfontein marked this pull request as ready for review October 7, 2024 19:45
@felixfontein felixfontein merged commit 4548580 into ansible-community:main Oct 7, 2024
5 checks passed
@felixfontein felixfontein deleted the changelog branch October 7, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants