Move parse_kev_term into the hashi_vault lookup #351 #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
Move parse_kev_term into the hashi_vault lookup
ADDITIONAL INFORMATION
parse_kev_term is used to parse key=value pairs from a term string for filling in options. It's only used in the hashi_vault lookup, but it currently exists in our lookup base class, and it really doesn't need to be there.
Since we plan to not support this method of supplying options in any other plugins, it is moved up into the one lookup where it's used.
The parse_kev_term here
https://github.com/ansible-collections/community.hashi_vault/blob/main/plugins/plugin_utils/_hashi_vault_lookup_base.py#L30-L47
is deleted from that class and moved to LookupModule class in hashi_vault.py in lookup folder
The parse_kev_term is just shifted from one class to other, thus there is no change in output.