Allow processing of a specific configuration file for libssh #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnerhacke
force-pushed
the
libssh-config-file
branch
from
75f66b9
to
914bf17
Compare
|
Link to the patch on the other side: ansible/pylibssh#479 |
donnerhacke
changed the title
donnerhacke
force-pushed
the
libssh-config-file
branch
from
1c5ec50
to
e83b095
Compare
Those failures seemed to be related to an unreachable test-system, not to the code. |
Qalthos
requested changes
Apr 3, 2023
Depending on the destination, libssh might need to be configured in a way, that the algorithms and methods need to be adjusted. Instead of adding each possible configuration option into the wrapper, including a config file (as it exists for ordinary OpenSSH) is much easier. This allows ansible to connect to devices with less well supported algorithms. This is a required step to fix connection issues with ansible.netcommon.libssh. The called ansible-pylibssh need to process the new optional argument config_file. But this is a separate patch, which needs to be applied there.
Qalthos
force-pushed
the
libssh-config-file
branch
from
55344fd
to
2247427
Compare
for more information, see https://pre-commit.ci
Qalthos
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Depending on the destination, libssh might need to be configured in a way, that the algorithms and methods need to be adjusted. Instead of adding each possible configuration option into the wrapper, including a config file (as it exists for ordinary OpenSSH) is much easier. This allows ansible to connect to devices with less well supported algorithms.
This is a required step to fix connection issues with ansible.netcommon.libssh. The called ansible-pylibssh need to process the new optional argument config_file. But this is a separate patch, which needs to be applied there.
ISSUE TYPE
COMPONENT NAME
ansible.netcommon.libssh
ADDITIONAL INFORMATION
Solve open connections issues with older devices, i.e.: #430