-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to build a circuit from vamp-ir source #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
paul/vamp-ir-from-source
branch
from
June 29, 2023 08:56
dbd7d2e
to
aa80600
Compare
paulcadman
force-pushed
the
paul/vamp-ir-from-source
branch
from
July 11, 2023 16:07
46e7714
to
c24bab4
Compare
XuyangSong
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There is only vamp-ir API for creating circuits inputs from a JSON file. Taiga will need to create inputs from note data stored in partial transactions. So we'll need API in vamp-ir to do this. The vamp-ir compile API could perhaps take a HashMap<String, Fp> of named assignments?
The vamp_ir_utils module consists of definitions that will eventually be incorporated into the vamp-ir library
When converting String->Fp assignments to VariableId->Fp assignments we should ignore variables with no name that are present in the vamp-ir module instead of panicing.
A user of from_vamp_ir_source may provide a named assigment that is not present in the vamp_ir module. Callers may want to handle this error to provide better feedback that panicing.
paulcadman
force-pushed
the
paul/vamp-ir-from-source
branch
from
July 11, 2023 17:52
c24bab4
to
08b9dfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only vamp-ir API for creating circuits inputs from a JSON file. Taiga will
need to create inputs from note data stored in partial transactions. So
we'll need API in vamp-ir to do this.
This PR adds API on
VampIRValidityPredicateCircuit
, for compiling a vamp-ir file from source.In
vamp-ir_utils
I've also added API missing from the vamp-ir library which we can add to vamp-ir later.and