Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data saver #1082

Closed
wants to merge 14 commits into from
Closed

Data saver #1082

wants to merge 14 commits into from

Conversation

LuftVerbot
Copy link
Member

Adds the Data Saver from TachiyomiSY.

Redo because old PR was scuffed or something. Don't know. Fuck lint and github

Sometimes it dosen't recognise the commonMain in source-api. This is a workaround so there are no problems with further coding. Is taken from a Tachiyomi commit
This adds the data saver from TachiyomiSY
@quickdesh quickdesh requested a review from jmir1 July 26, 2023 03:11
@LuftVerbot LuftVerbot requested a review from jmir1 July 26, 2023 12:57
@quickdesh
Copy link
Contributor

I would suggest renaming the exh package since thats mostly for Syer's ExHentai stuff. better to just name it something more generic

@jmir1
Copy link
Member

jmir1 commented Jul 26, 2023

Maybe aniyomi instead of fork?

@@ -0,0 +1,5 @@
package aniyomi.source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even used anywhere?
Sorry if I missed something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay but I don't see how this has any relevance because I believe this is related to SY's "special" sources

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quickdesh I think you used SY, right? What is this for?

Copy link
Member Author

@LuftVerbot LuftVerbot Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure at moment of implementing. Thats why I left it

Copy link
Contributor

@quickdesh quickdesh Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged Manga and Lewd are SY special sources, yes. These can be removed since they don't affect Aniyomi

@LuftVerbot
Copy link
Member Author

Will reopen the pr. Messed some things up on my side

@LuftVerbot LuftVerbot closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants