feat: release pipeline #3
Conversation
Signed-off-by: Berend Sliedrecht <[email protected]>
| npm config set //registry.npmjs.org/:_authToken $NPM_TOKEN | ||
|
|
||
| if [ ${{ inputs.release-type }} == 'alpha' ]; then | ||
| pnpm release --preRelease=alpha |
There was a problem hiding this comment.
do we also need to provide the release type here? E.g. if we're on 1.0.0 now, if we do alpha release should it be 1.0.1-alpha.0, 1.1.0-alpha.0, or 2.0.0-alpha.0?
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "git": { | |||
| "commitMessage": "chore: release v${version}" | |||
There was a problem hiding this comment.
If it makes a commit on release, we should also push that commit. But I don't see support for that in the current CI setup.
There was a problem hiding this comment.
We can probably give the CI push access. See https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
There was a problem hiding this comment.
But if we enable branch protection it won't be possible anymore. So we either need to take the approach of not commiting when we make a release (as we do in more libraries, by not looking at package.json for the next version), or we need to disable brancn protectino and allow pushing to main, or we need to make a PR first to increase the version, and based on that trigger a release.
I'm fine with a simple solution for now
| "version": "0.0.0", | ||
| "main": "build/index.js", | ||
| "author": "Animo Solutions <[email protected]> (https://animo.id)", | ||
| "author": "Animo Solutions <[email protected]> (https://www.animo.id)", |
There was a problem hiding this comment.
Woot. https://www.animo.id doesn't seem to work. I'll look into into it, but why not just https://animo.id?
There was a problem hiding this comment.
lol thats weird, we are not on the world wide web!!!!
https://animo.id works as well, I prefer the looks of www haha.
Signed-off-by: Berend Sliedrecht [email protected]