v3.0.0

[ykmnkmi]

No description provided.

[GZGavinZhao]

Should the lower bound of the SDK stay at 3.0.0 instead of 3.1.0 for maximum compatibility?

[ykmnkmi]

@GZGavinZhao mockito 5.4.3 which requires Dart SDK version ^3.1.0.

[GZGavinZhao]

Oh yes, you're right. Well, that's sad, we have to keep the min SDK bound at 3.1.0 then.

[ykmnkmi]

Dart 3.2 is already released. _tests/test is not updated. I also noticed old doc. comments to update.

[GZGavinZhao]

I think we should keep min SDK bound to 3.1 unless there are packages/language features that prevents us from doing so.

Regarding _tests/test, locally I was able to migrate all files to Dart 3 except 3:

• _tests/test/core/linker/security_integration_test.dart
• _tests/test/compiler/output/dart_emitter_test.dart
• _tests/test/compiler/ast_directive_normalizer_test.dart

I managed to migrate all of them. Browser tests (-P browser) there were 2 failures (+787 ~11 -2), but I think those are trivial fixes. The real problem is with the vm tests (-P vm) (+159 ~4 -59). A majority of them are type 'Null' is not a subtype of X errors.

I'm not sure how I should merge the changes with yours. Do you want me to push to your existing working branch directly? I pushed the existing work on top of yours into the dart3 branch here. Feel free to work on top of those changes.

[ykmnkmi]

Some tests show that mock-like behavior is not supported in null-safety mode:

group('should be mock-like', () {
  mockLikeTests(nullSafe: false);
});

group('should never be mock-like when opted-in to null-safety', () {
  mockLikeTests(nullSafe: true);
});

Maybe remove all mock-like tests? I try to disable the null-safety option in the compile context.

[ykmnkmi]

Found this:

/// Whether this output has mock-like behavior.
///
/// The heuristic used to determine mock-like behavior is if the analyzed
/// class or one of its ancestors, other than [Object], implements
/// [noSuchMethod].
///
/// Note that is the value is _never_ true for null-safe libraries, as we no
/// longer support null streams/stream subscriptions in the generated code.

[GZGavinZhao]

I think this is ready for merge?

[ykmnkmi]

@GZGavinZhao yes.