-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Marketplace & Auction Adjustments #589
Open
joemonem
wants to merge
12
commits into
development
Choose a base branch
from
marketplace-adjustments
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+608
−156
Open
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
eeec204
feat: allow multiple authorized cw20 addresses in marketplace, add an…
joemonem 5d7a931
feat: query authorized addresses, unit test
joemonem a5c042f
chore: linting
joemonem 9ba6c1d
feat: add or remove authorized cw721 addresses in marketplace
joemonem d44f899
chore: version change
joemonem 44425d9
ref: unify authorize and deauthorize functions in common
joemonem 1125f40
feat: allow multiple authorized addresses in auction #586
joemonem 1ed0652
chore: version bump for auction
joemonem 838c6bf
ref: move AuthorizedAddressesResponse to common
joemonem 53f1a81
ref: authorize_addresses function used in auction and marketplace
joemonem cb9fee8
chore: linting
joemonem 8dbd52b
chore: changelog entry
joemonem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardize pagination limit type across query functions.
The
limit
parameter type inquery_authorized_addresses
isOption<u32>
, while other query functions in this file (e.g.,query_auction_infos_for_address
,query_bids
) useOption<u64>
. Consider standardizing the pagination limit type for consistency.Apply this diff:
📝 Committable suggestion