Add safer intents sample #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrezgui
commented
May 22, 2024
| @@ -34,7 +34,7 @@ android { | |||
|
|
|||
| defaultConfig { | |||
| applicationId = "com.example.platform.app" | |||
| minSdk = 21 | |||
There was a problem hiding this comment.
We're not looking to upgrade our minSdk to 24. You should use RequiresApi annotation around your sample instead
| } | ||
| @Composable | ||
| fun HelloAndroidScreen() { | ||
| Text(text = "Hello Android!") |
There was a problem hiding this comment.
Inline this function directly inside the Surface composable
| <activity android:name=".SaferIntentsActivity" | ||
| android:exported="true"> | ||
| <intent-filter> | ||
| <action android:name="com.example.platform.security.intents.MY_ACTION" /> |
There was a problem hiding this comment.
Without this intent action filter, will this activity be launched with the NULL intent? If yes, explain it in comments
Update the timeout to check if the test can be run
Update some github action version to latest (older are being deprecated) Update min api level to 27
Changing emulator host because x86_64 does not run on arm64
Update api level to 31
Move the base api level to 31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.