Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocomplete_js improvements #18630

Closed
wants to merge 33 commits into from
Closed

autocomplete_js improvements #18630

wants to merge 33 commits into from

Conversation

Q-back
Copy link
Collaborator

@Q-back Q-back commented Jun 26, 2020

  1. It includes merge from Fix/parsing openapi #18612
  2. It includes merge from Feature/improve autocomplete js #18552
  3. It adds info about failed CSS selectors to report file.
  4. Added TestPluginRunner class which is a tool for testing every plugin with clean API. It's intended to be a simple to use fixture.

Q-back added 30 commits May 4, 2020 18:14
@Q-back
ignore __pychace__/ and another script file pattern (for tests)
bf12c08
@Q-back
automatically marked slow and deprecated tests, added pytest.ini
fa7f743
@Q-back
added pytest to tests requirements
3c26cf1
@Q-back
brought back FormInputSubmitStrategy, better alghoritm of discovering…
50cb5a5 
… username input and login button
@Q-back
fix _handle_authentication_success breaking parent's functionality in…
13a5d0d 
… autocomplete_js
@Q-back
revert enabling FormInputSubmitStrategy from pre-previous commit
e04104f
@Q-back
new options in autocomplete_js to manually provide username/submit bu…
389646d 
…tton CSS selectors
@Q-back
don't create new chrome instance when running autocomplete_js.has_act…
52b8f39 
…ive_session()
@Q-back
fix after rebase
2192ca5
@Q-back
reloading chrome when checking active session may break the session
1723b6b
@Q-back
implemented _login_using_existing_form
b81b71d
@Q-back
fix iterate error in frame manager, don't kill chrome in autocomplete…
d4b6531 
…_js.has_active_session if chrome belongs to outer scope
@Q-back
better description for new params in autocomplete_js
25a1125
@Q-back
sometimes login button doesn't contain 'log' characters in it's text,…
888eea6 
… so we return all buttons in parent node
@Q-back
add option to click on element before autocompleting form
27ede04
@Q-back
deleted conftest.py from root directory
b76cf07
@Q-back
remove unused pytest imports
c68a45a
@Q-back
marked other failing tests
f92a9ae
@Q-back
added tests to docs
04ec9bc
@Q-back
fix error when user provides CSS selectors with quotes. Slightly bett…
5854763 
…er exception handling during js login process
@Q-back
fix UnicodeDecodeError when parsing openapi spec
0b8b3f0
@Q-back
fix request error when not required array param in open_api spec
2e88cc2
@Q-back
fix error when empty list was returned by querySelectorAll to Instrum…
8d520bc 
…entedChrome.focus() method
@Q-back
Merge branch 'fix/tests' into holm-master
8cbbfa9
@Q-back
Merge branch 'upstream-develop' into holm-master
ad54e10
@Q-back
Merge remote-tracking branch 'upstream/feature/improve-autocomplete_j…
fddafa2 
…s' into holm-master
@Q-back
fix typo in pytestmark
ea9e923
@Q-back
function-based plugin runner
5e49d49
@Q-back
test runner class-based, prepared css selector test
9eb78c7
@Q-back
mocking network in plugin_runner, autocomplete_js reports CSS selecto…
d5a54f7 
…rs failure
@Q-back
Copy link
Collaborator Author

Q-back commented Jun 26, 2020

closes #18612
closes #18552

@Q-back Q-back mentioned this pull request Jul 14, 2020
Open
@Q-back
Copy link
Collaborator Author

Q-back commented Jul 14, 2020

Continued at #18645

@Q-back Q-back closed this Jul 14, 2020
@Q-back Q-back deleted the feature/improve-report-autocomplete_js branch July 14, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresriancho andresriancho Awaiting requested review from andresriancho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Q-back