Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zoomin and zoomout events #334

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

jhhend
Copy link

@jhhend jhhend commented Apr 4, 2024

Hello there,

We use simplelightbox and found that one of our clients wanted extra functionality added to the lightbox when the user zoomed in/out of an image. I achieved the functionality we needed via a MutationObserver, but thought that events which can be triggered on zoom would be quite helpful.

I understand that this is not comprehensive, since it does not cover pinch zooming or double tapping - I am open to hearing thoughts on how to make this more comprehensive, if needed, just opening this request for visibility.

Thanks so much for your commitment and dedication to maintaining this tool.

@Mtillmann
Copy link
Collaborator

Hi @jhhend this looks like a great addition. Thanks for opening the PR. I think this is a good addition for the next major-ish release

@jhhend
Copy link
Author

jhhend commented Apr 9, 2024

Hi @jhhend this looks like a great addition. Thanks for opening the PR. I think this is a good addition for the next major-ish release

This is great to hear. Let me know of any extra functionality or requirements this would need to meet the standards for release. I will be watching this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants