Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy properties along with artifacts #190

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

aslheyrr
Copy link
Contributor

@aslheyrr aslheyrr commented Sep 18, 2024

Description

Artifactory REST API supports deploying artifacts and properties in a single operation. This is particularly useful so that you don't have to make any additional API calls to set properties.

This PR enables the deployment of artifacts and properties (optional parameter) in the same request.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has it been tested ?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My PR is ready for prime time! Otherwise use the "Draft PR" feature
  • All commits have a correct title
  • Readme has been updated
  • Quality tests are green (see Codacy)
  • Automated tests are green (see pipeline)

@anancarv
Copy link
Owner

Hey @aslheyrr,
I do not see that feature on the Artifactory API. Can you please point me to the corresponding documentation?

@aslheyrr
Copy link
Contributor Author

Hi @anancarv
This is where I found it https://jfrog.com/help/r/jfrog-artifactory-documentation/using-properties-in-deployment-and-resolution

Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are just some minor changes required. But the MR looks good

README.md Outdated Show resolved Hide resolved
pyartifactory/objects/artifact.py Outdated Show resolved Hide resolved
Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@anancarv anancarv merged commit 55675c4 into anancarv:master Sep 20, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants