-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add support for Array-Type in JSON #42
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
@anuragkh PR is currently WIP, but wanted to check if the approach was alright |
Hi @muditsin, thanks for contributing! The approach looks about right to me, although there is some code duplication (e.g., parsing the values in the array is the same as parsing individual values). Perhaps making them modular might help reduce code redundancy. |
@anuragkh Updated to reduce duplication. Thanks! |
Jenkins, test this please. |
1 similar comment
Jenkins, test this please. |
Test FAILed. Build result: FAILURE[...truncated 216 lines...][INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project succinct-serde: Compilation failure[ERROR] /home/jenkins/workspace/Succinct-PRB/serde/src/main/java/edu/berkeley/cs/succinct/object/deserializer/JsonDeserializer.java:[119,54] error: ';' expected[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :succinct-serde[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/assembly/pom.xml to amplab/succinct-assembly/0.1.8/succinct-assembly-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/pom.xml to amplab/succinct/0.1.8/succinct-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/spark/pom.xml to amplab/succinct-spark/0.1.8/succinct-spark-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/serde/pom.xml to amplab/succinct-serde/0.1.8/succinct-serde-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/core/pom.xml to amplab/succinct-core/0.1.8/succinct-core-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/core/target/succinct-core-0.1.8.jar to amplab/succinct-core/0.1.8/succinct-core-0.1.8.jar[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/core/target/succinct-core-0.1.8-tests.jar to amplab/succinct-core/0.1.8/succinct-core-0.1.8-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/core/target/succinct-core-0.1.8-jar-with-dependencies.jar to amplab/succinct-core/0.1.8/succinct-core-0.1.8-jar-with-dependencies.jarSending e-mails to: [email protected] stoppedTest FAILed. |
Jenkins, test this please. |
2 similar comments
Jenkins, test this please. |
Jenkins, test this please. |
@muditsin, Jenkins is only triggered by repo admins and whitelisted committers atm. I'll add you to whitelist. |
Jenkins, add to whitelist. |
Test PASSed. |
Test PASSed. |
@muditsin Can you please add tests for the new data types you have added? |
@anuragkh Sure |
Fixes: #35