Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds writers for Fields, OrderedElements, and logic constraints #292

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None

Description of changes:

  • Adds writers for more constraints.
  • Adds convenience constructors for constraints that accept a list of type arguments
  • Adds factory methods for constructing a VariablyOccuringTypeArgument from a TypeArgument
  • Moves writeTypeArguments from the TypeWriter interface to be an extension function instead.

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from desaikd October 12, 2023 03:49
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...n/ionschema/model/VariablyOccurringTypeArgument.kt 88.88% <83.33%> (ø)
...com/amazon/ionschema/writer/internal/TypeWriter.kt 0.00% <0.00%> (ø)
...schema/writer/internal/constraints/FieldsWriter.kt 72.72% <72.72%> (ø)
...in/kotlin/com/amazon/ionschema/model/Constraint.kt 70.90% <50.00%> (ø)
...iter/internal/constraints/OrderedElementsWriter.kt 0.00% <0.00%> (ø)
...ter/internal/constraints/LogicConstraintsWriter.kt 0.00% <0.00%> (ø)

... and 132 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@desaikd desaikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@popematt popematt merged commit 03dd056 into amazon-ion:master Oct 18, 2023
4 of 5 checks passed
@popematt popematt deleted the writer-part-4 branch October 18, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants