Enables Windows and Linux build test #304
Conversation
|
wheels build succeed on Windows - https://github.com/amazon-ion/ion-python/actions/runs/7010773623/job/19072109850?pr=304 |
tests/test_benchmark_spec.py
Outdated
| size = _minimal_spec.get_input_file_size() | ||
| if platform.system() == 'Windows': | ||
| assert size == 167 | ||
| else: | ||
| assert size == 161 |
There was a problem hiding this comment.
Can you please add some commentary to explain this?
There was a problem hiding this comment.
Added, the sample file cat.ion has different file size according to the operating systems.
tests/test_benchmark_spec.py
Outdated
| size = _minimal_spec.get_input_file_size() | ||
| # Different operating systems use different file structures, which, as a result, leads to varying amounts of | ||
| # space being used for storing files. | ||
| if platform.system() == 'Windows': | ||
| assert size == 167 | ||
| else: | ||
| assert size == 161 |
There was a problem hiding this comment.
Are we gaining anything by asserting the apparently platform-dependent size, as opposed to, e.g., just the name of the file?
There was a problem hiding this comment.
Discussed offline, comparing the returned size against the expected size retrieved by the method Path(join(_generate_test_path("sample_spec"), _minimal_params['input_file'])).stat().st_size
where join(_generate_test_path("sample_spec"), _minimal_params['input_file']) indicates cat.ion
|
Tests passed. Only few failures are due to the performance regression variance |
This PR enables build tests on Windows and Linux and unblocks the current release pipeline issue.
In details, this PR
tabulateon Windows. #307By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.