Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark results report doesn't support tabulate on Windows. #307

Open
cheqianh opened this issue Nov 27, 2023 · 0 comments
Open

Benchmark results report doesn't support tabulate on Windows. #307

cheqianh opened this issue Nov 27, 2023 · 0 comments
Labels
benchmark ion-python-benchmark-cli bug

Comments

@cheqianh
Copy link
Contributor

cheqianh commented Nov 27, 2023 •
edited
Loading

When running below on the GHA Windows runner.

python ./amazon/ionbenchmark/ion_benchmark_cli.py compare ./tests/benchmark_sample_data/compare/cats_baseline.ion ./tests/benchmark_sample_data/compare/cats_baseline.ion --fail

It throws

UnicodeEncodeError: 'charmap' codec can't encode characters in position 0-64: character maps to <undefined>

We disabled log output table for Windows.

Detailed code, see - https://github.com/amazon-ion/ion-python/blob/master/amazon/ionbenchmark/ion_benchmark_cli.py#L115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark ion-python-benchmark-cli bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cheqianh