Use enum's constructor to resolve enum values #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than creating a map of
{value: enum}
, let's just useFoo(value)
to resolve to the respective enum value.This fixes a regression with introspection introduced in commit 3282eed "Improve unmarshall performance":
MESSAGE_FLAG_MAP is built like this:
But MessageFlag is a IntFlag, so the zero value (NONE) is missing from the iterator:
Resolving the enum through the constructor fixes this. MESSAGE_TYPE_MAP and HEADER_NAME_MAP are changed in solidarity.
Fixes #142