Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octo: 8th release recommendation #531

Merged
merged 1 commit into from
Oct 3, 2024
Merged

octo: 8th release recommendation #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/cover/recommendation/aws.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ message AWSResourceDetails {
message EC2Details {
message InstanceDetails {
string type = 1;
string architecture = 11;
string tenancy = 2;
string platform = 3;
string family = 4;
Expand Down
9 changes: 8 additions & 1 deletion api/cover/recommendation/octoaws.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,15 @@ option go_package = "github.com/alphauslabs/blue-sdk-go/api/cover/recommendation
option java_package = "cloud.alphaus.blueapi.api.cover.recommendation";
option java_outer_classname = "ApiCoverOctoAwsRecommendationProto";

import "api/cover/recommendation/aws.proto";

message OctoGeneratedAWSRecommendations {

message Details {
api.cover.recommendation.aws.AWSResourceDetails.EC2Details ec2Details = 1;
}

Details currentDetails = 1;
Details recommendationDetails = 2;
}


Expand Down
1 change: 1 addition & 0 deletions api/cover/recommendation/recommendation.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ message RecommendationData {
bool restartNeeded = 20;
bool rollbackPossible = 21;
string launchUrl = 22;
string vendor = 24;
}

message OCTOGeneratedRecommendations {
Expand Down
24 changes: 23 additions & 1 deletion openapiv2/apidocs.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13274,6 +13274,9 @@
"type": {
"type": "string"
},
"architecture": {
"type": "string"
},
"tenancy": {
"type": "string"
},
Expand Down Expand Up @@ -21876,7 +21879,23 @@
"description": "The `Status` type defines a logical error model that is suitable for\ndifferent programming environments, including REST APIs and RPC APIs. It is\nused by [gRPC](https://github.com/grpc). Each `Status` message contains\nthree pieces of data: error code, error message, and error details.\n\nYou can find out more about this error model and how to work with it in the\n[API Design Guide](https://cloud.google.com/apis/design/errors)."
},
"octoawsOctoGeneratedAWSRecommendations": {
"type": "object"
"type": "object",
"properties": {
"currentDetails": {
"$ref": "#/definitions/octoawsOctoGeneratedAWSRecommendationsDetails"
},
"recommendationDetails": {
"$ref": "#/definitions/octoawsOctoGeneratedAWSRecommendationsDetails"
}
}
},
"octoawsOctoGeneratedAWSRecommendationsDetails": {
"type": "object",
"properties": {
"ec2Details": {
"$ref": "#/definitions/awsAWSResourceDetailsEC2Details"
}
}
},
"octoazurecspOctoGeneratedAzureCSPRecommendations": {
"type": "object"
Expand Down Expand Up @@ -22052,6 +22071,9 @@
},
"launchUrl": {
"type": "string"
},
"vendor": {
"type": "string"
}
}
},
Expand Down
Loading