Issue-237: updateValidPosts check does not pass post types and only checks for valid posts, other post types fail
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboynes
approved these changes
Sep 27, 2024
mogmarsh
deleted the
fix/issue-237/updateValidPosts-fails-custom-post-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue described in #237 - Fixes #237
Description of the bug
When pinning a post from a custom post type (not post), you receive a warning that the post has been deleted and you cannot pin the post.
Solution
The validation has been updated to allow additional post types, ensuring that posts of custom types can be pinned without triggering a deletion warning.
Steps To Reproduce
Pin a post not of type 'post'
Additional Information
No response