Revert "Adds filter to control max number of posts in query block"

alleyinteractive · Sep 4, 2024 · 90e57ec · 90e57ec
1 parent 080fc12
commit 90e57ec
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/blocks/query/block.json b/blocks/query/block.json
@@ -31,6 +31,10 @@
       ],
       "type": "string"
     },
+    "maxNumberOfPosts": {
+      "default": 10,
+      "type": "number"
+    },
     "minNumberOfPosts": {
       "default": 1,
       "type": "number"

diff --git a/blocks/query/edit.tsx b/blocks/query/edit.tsx
@@ -47,7 +47,6 @@ interface Window {
     allowedPostTypes: Array<string>;
     allowedTaxonomies: Array<string>;
     parselyAvailable: string,
-    maxPosts: number,
   };
 }
 
@@ -63,6 +62,7 @@ export default function Edit({
   attributes: {
     backfillPosts = [],
     deduplication = 'inherit',
+    maxNumberOfPosts = 10,
     minNumberOfPosts = 1,
     numberOfPosts = 5,
     offset = 0,
@@ -82,7 +82,6 @@ export default function Edit({
       allowedPostTypes = [],
       allowedTaxonomies = [],
       parselyAvailable = 'false',
-      maxPosts = 10,
     } = {},
   } = (window as any as Window);
 
@@ -327,14 +326,14 @@ export default function Edit({
           title={__('Setup', 'wp-curate')}
           initialOpen
         >
-          {minNumberOfPosts !== undefined && minNumberOfPosts !== maxPosts ? (
+          {minNumberOfPosts !== undefined && minNumberOfPosts !== maxNumberOfPosts ? (
             <RangeControl
               label={__('Number of Posts', 'wp-curate')}
               help={__('The maximum number of posts to show.', 'wp-curate')}
               value={numberOfPosts}
               onChange={setNumberOfPosts}
               min={minNumberOfPosts}
-              max={maxPosts}
+              max={maxNumberOfPosts}
             />
           ) : null}
           <RangeControl

diff --git a/blocks/query/index.php b/blocks/query/index.php
@@ -43,13 +43,6 @@ function wp_curate_query_block_init(): void {
 	 */
 	$allowed_taxonomies = apply_filters( 'wp_curate_allowed_taxonomies', [ 'category', 'post_tag' ] );
 
-	/**
-	 * Filter the maximum number of posts that can be displayed in the Query block.
-	 *
-	 * @param integer $max_posts The maximum number of posts to display.
-	 */
-	$max_posts = apply_filters( 'wp_curate_max_posts', 10 );
-
 	/**
 	 * Filter whether to use Parsely.
 	 *
@@ -63,7 +56,6 @@ function wp_curate_query_block_init(): void {
 			'allowedPostTypes'  => $allowed_post_types,
 			'allowedTaxonomies' => $allowed_taxonomies,
 			'parselyAvailable'  => $parsely_available ? 'true' : 'false',
-			'maxPosts'          => $max_posts,
 		]
 	);
 }

diff --git a/blocks/query/types.ts b/blocks/query/types.ts
@@ -2,6 +2,7 @@ interface EditProps {
   attributes: {
     backfillPosts?: number[];
     deduplication?: string;
+    maxNumberOfPosts?: number;
     minNumberOfPosts?: number;
     numberOfPosts?: number;
     offset?: number;