Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping to mantle-framework/testkit v1 and PHPUnit 10 #290

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Nov 30, 2023

  • Upgrades to Testkit version 1.0 and PHPUnit 10.
  • Bumps PHP to 8.1+.

Summary by CodeRabbit

  • Documentation

    • Updated the PHP version requirement in the README to reflect the new minimum version of 8.1.
  • Chores

    • Modified the continuous integration workflow to test against PHP versions 8.1 and 8.2, dropping support for version 8.0.
  • Bug Fixes

    • Adjusted the version check in the configuration to enforce the new PHP version requirement of 8.1.0 or greater.

Copy link

coderabbitai bot commented Nov 30, 2023

Walkthrough

The project has updated its PHP version requirements, dropping support for PHP 8.0 and now requiring a minimum of PHP 8.1. This change is reflected across workflow configurations and code checks, ensuring that tests are run on the new minimum version and that the system will enforce the updated version requirement.

Changes

File Path Change Summary
.github/workflows/.../unit-test.yml Updated PHP matrix to include versions 8.1 and 8.2, removed version 8.0
README.md Modified PHP version requirement from 8.0 to 8.1
configure.php Updated the version check to enforce PHP 8.1.0 or greater

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question about mysql version, otherwise 👍

buddy.yml Outdated
@@ -53,7 +53,7 @@
- "echo \"extension=memcache.so\" >> /usr/local/etc/php/conf.d/buddy.ini"
services:
- type: "MYSQL"
version: "8.0"
version: "1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope!

@srtfisher srtfisher merged commit 9341fa6 into develop Nov 30, 2023
7 of 8 checks passed
@srtfisher srtfisher deleted the mantle-v-1 branch November 30, 2023 22:14
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 31480a6 and 5a16c38.
Files ignored due to filter (2)
  • composer.json
  • phpunit.xml
Files selected for processing (3)
  • .github/workflows/unit-test.yml (1 hunks)
  • README.md (1 hunks)
  • configure.php (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/unit-test.yml
Additional comments: 3
README.md (1)
  • 39-45: The PHP version requirement has been correctly updated in the README.md to reflect the new minimum version of 8.1 as per the summary.
configure.php (2)
  • 27-28: The PHP version check has been correctly updated to enforce PHP 8.1.0 or greater as per the summary.

  • 27-28: Verify that all documentation and CI/CD configurations have been updated to reflect the new PHP version requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants