-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping to mantle-framework/testkit v1 and PHPUnit 10 #290
Conversation
WalkthroughThe project has updated its PHP version requirements, dropping support for PHP 8.0 and now requiring a minimum of PHP 8.1. This change is reflected across workflow configurations and code checks, ensuring that tests are run on the new minimum version and that the system will enforce the updated version requirement. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question about mysql version, otherwise 👍
buddy.yml
Outdated
@@ -53,7 +53,7 @@ | |||
- "echo \"extension=memcache.so\" >> /usr/local/etc/php/conf.d/buddy.ini" | |||
services: | |||
- type: "MYSQL" | |||
version: "8.0" | |||
version: "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- composer.json
- phpunit.xml
Files selected for processing (3)
- .github/workflows/unit-test.yml (1 hunks)
- README.md (1 hunks)
- configure.php (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/unit-test.yml
Additional comments: 3
README.md (1)
- 39-45: The PHP version requirement has been correctly updated in the README.md to reflect the new minimum version of 8.1 as per the summary.
configure.php (2)
27-28: The PHP version check has been correctly updated to enforce PHP 8.1.0 or greater as per the summary.
27-28: Verify that all documentation and CI/CD configurations have been updated to reflect the new PHP version requirement.
Summary by CodeRabbit
Documentation
Chores
Bug Fixes