Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SQLite by default #280

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Disable SQLite by default #280

merged 2 commits into from
Nov 15, 2023

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Nov 15, 2023

Disable SQLite by default for newly scaffolded plugins.

Fixes #268.

Summary by CodeRabbit

  • Tests
    • Updated the testing setup for improved compatibility and performance.
  • Chores
    • Adjusted code quality tool configurations to streamline development processes.

Copy link

coderabbitai bot commented Nov 15, 2023

Walkthrough

The changes involve updating the testing configuration for a WordPress plugin. A PHP CodeSniffer rule has been disabled, a note about syncing the plugin with rsync during testing has been added, and the use of SQLite for testing has been commented out. These modifications streamline the testing process and potentially address compatibility and environment setup concerns.

Changes

File Change Summary
tests/bootstrap.php Disabled PHP CodeSniffer rule, added rsync comment, commented out SQLite usage

Assessment against linked issues (Beta)

Objective Addressed Explanation
Determine if the with_sqlite feature in Mantle should be loaded by default (#268) The change comments out the SQLite usage, which suggests a move away from loading it by default, but it's unclear if this is a final decision or a temporary workaround.
Consider compatibility with older versions of Mantle that may not have the with_sqlite method (#268) There is no direct evidence in the provided summary that compatibility with older versions of Mantle has been considered.
Evaluate the necessity of having with_sqlite as an optional feature (#268) Commenting out the SQLite usage indicates consideration of its necessity, but there's no clear decision or rationale provided.
Assess the impact on projects without a local installation of SQLite, especially in relation to different PHP versions (#268) The summary does not provide information on the assessment of the impact on projects without SQLite or on different PHP versions.
Review the provided link for additional context on the issue with older Mantle versions (#268) The summary does not mention a review of additional context provided by a link, so this objective appears unaddressed.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@srtfisher srtfisher marked this pull request as ready for review November 15, 2023 16:11
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d5224cf and 116e1ef.
Files ignored due to filter (1)
  • phpunit.xml
Files selected for processing (1)
  • tests/bootstrap.php (1 hunks)
Files skipped from review due to trivial changes (1)
  • tests/bootstrap.php

Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@srtfisher srtfisher merged commit 62b818d into develop Nov 15, 2023
7 of 9 checks passed
@srtfisher srtfisher deleted the feature/sqlite-opt-out branch November 15, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not load with_sqlite in Mantle by default
2 participants