-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-582: Provide fast refresh when developing for scripts in package plugin #594
Merged
stevenslack
merged 9 commits into
main
from
feature/issue-582/fast-refresh-for-package-plugin-dev
Mar 13, 2024
Merged
Issue-582: Provide fast refresh when developing for scripts in package plugin #594
stevenslack
merged 9 commits into
main
from
feature/issue-582/fast-refresh-for-package-plugin-dev
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e29b3c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
renatonascalves
requested changes
Mar 12, 2024
Co-authored-by: Renato Alves <[email protected]>
…of github.com:alleyinteractive/alley-scripts into feature/issue-582/fast-refresh-for-package-plugin-dev
renatonascalves
approved these changes
Mar 13, 2024
stevenslack
deleted the
feature/issue-582/fast-refresh-for-package-plugin-dev
branch
March 13, 2024 12:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to be able to run dev mode in any of the
alley-scripts/packages/*
while also running dev mode in thealley-scripts/plugin
so that I can work on the scripts without having to runnpm run build
and refresh the page in order to see the changes.Documentation also needs to be provided in order for developers to properly get set up to develop in the plugin accordingly.
Use Case
Example:
In the directory
alley-scripts/packages/block-editor-tools
runnpm run dev
in the command line to run Webpack development mode with the watch flag so that the files will recompile whenever they change.webpack --mode=development --watch
.Simultaneously in the
alley-scripts/plugin
directory I want to runnpm run dev
ornpm run start
while importing or linking with npm link theblock-editor-tools
to see my changes when the files change.By using a relative path import to the development plugin we can allow for fast refresh when developing in packages such as the block editor tools.
Related issue: Provide fast refresh when developing for scripts in package plugin