Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --limit-bytes to diff command to truncate output in github actions #208

Merged
merged 3 commits into from
May 27, 2023

Conversation

allenporter
Copy link
Owner

Add a default limit so that very large diffs do not fail github actions

Issue #207

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023

Codecov Report

Merging #208 (862cd55) into main (17b6e79) will decrease coverage by 0.53%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   91.73%   91.20%   -0.53%     
==========================================
  Files          15       15              
  Lines        1512     1524      +12     
==========================================
+ Hits         1387     1390       +3     
- Misses        125      134       +9     
Impacted Files Coverage Δ
flux_local/tool/diff.py 85.93% <41.17%> (-4.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

The limit code won't really run, however, given there are no diffs.
@allenporter allenporter merged commit f0d5a85 into main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants