Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: update bart #19

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

WIP: update bart #19

wants to merge 8 commits into from

Conversation

danyaljj
Copy link
Contributor

@danyaljj danyaljj commented Apr 4, 2021 •
edited
Loading

PR corresponding to #17

@danyaljj danyaljj requested a review from shmsw25 April 4, 2021 02:49
@shmsw25
Copy link
Contributor

shmsw25 commented Apr 8, 2021

It looks good! I propose to merge it to a different branch (e.g. bart-hf-v4) because re-runing finetuning with a newer version of HF is not tested. People can use HF v4 if they do not want to re-run finetuning but only want to run inference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmsw25 shmsw25 Awaiting requested review from shmsw25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danyaljj @shmsw25 @timhartill