grobid augmenter - fix Sections-Paragraphs bug #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/allenai/scholar/issues/38452 and https://github.com/allenai/scholar/issues/39910
This fixes a bug that was resulting in sections that had paragraphs but no sentences, which resulted in an error in pipeline-elements in SPP.
then (from initial investigation notes in https://github.com/allenai/scholar/issues/38452#issuecomment-1821935080) -- section id 4 has a paragraph but no sentences (paragraphs come from sentences so this didn't make sense):
The problem was in the python control flow where paragraphs were being added to even if we weren't adding the sentences (due to the sentence text already being claimed by the previous duplicate section -- due to it being a weird PDF and Grobid giving double sections -- more details on that under "continued investigation notes 11/29:" in the same investigation notes comment linked above)
now -- no empty paragraph/sentence-less section!
todo: