bugfix for box_groups_to_span_groups when center=True #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@regan-huff could you try merging this for me? for some reason the button isn't working for me, appears to be and then goes back to "Confirm squash and merge" after a little while
|
|
@geli-gel failed for me too, will try again in a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bug fix for an error made in #276
It's possible to find tokens from the original Document overlapping with the MergedSpan SpanGroup that are already allocated to a different SpanGroup, so we need to check first if it's in the list of available tokens before attempting to remove it.
todo: