Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include symbols btwn disjoints #277

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Include symbols btwn disjoints #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b4e727
test is ready and failing at the right spot
geli-gel Aug 23, 2023
8944524
stringify.py include_symbols_between_disjoint_spans
geli-gel Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/mmda/utils/stringify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,10 @@ def stringify_span_group(
)
else:
logger.debug(f"span_group {span_group} has disjoint spans")
if include_symbols_between_disjoint_spans:
# TODO: easiest is probably to convert disjoint spans into a single longer span
raise NotImplementedError

# if matched words are disjoint, what should we do with the in-between symbols when stringifying?
if Span.are_disjoint(spans=[span for word in matched_words for span in word.spans]):
word_spans = [span for word in matched_words for span in word.spans]
if Span.are_disjoint(spans=word_spans):
if not allow_disjoint_spans:
raise ValueError(
f"span_group {span_group} intersects words {matched_words} which have disjoint spans but allow_disjoint_spans is False"
Expand All @@ -91,8 +89,16 @@ def stringify_span_group(
f"span_group {span_group} intersects words {matched_words} which have disjoint spans"
)
if include_symbols_between_disjoint_spans:
# TODO: easiest is probably to convert disjoint spans into a single longer span
raise NotImplementedError
matched_words = document.find_overlapping(
SpanGroup(
spans=[
Span(
start=matched_words[0].start, end=matched_words[-1].end
)
]
),
"words",
)

# TODO: actually, maybe refactor this. it doesnt matter if query spangroup is disjoint
# the actual handling should just happen if it's disjoint words.
Expand Down
Loading
Loading