group boxes into lines with tolerance #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geli-gel
approved these changes
Aug 15, 2023
|
Looks like this will improve things but wondering if we could take advantage of PDFPlumber's line segmentation ( |
|
Just realized a version bump is needed here, I'm setting it to 0.9.11 in my PR so you can take 0.9.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR groups boxes into lines without assuming a perfect match of
box.t. We use the 3rd decimal point which seems small enough but also big enough to catch most cases.This PR also merges adjacent boxes belonging to a mention which might have 2 spans that are far apart. Instead of not doing anything in that case, it only merges boxes with associated spans that are close.