Update allennlp dependency (#21)

* Update allennlp dependency * fix calls to Embedding() Co-authored-by: Matt Gardner <[email protected]>
allenai · Feb 20, 2020 · 339e617 · 339e617
1 parent e1ff04c
commit 339e617
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/allennlp_semparse/models/atis/atis_semantic_parser.py b/allennlp_semparse/models/atis/atis_semantic_parser.py
@@ -122,7 +122,7 @@ def __init__(
 
         self._num_entity_types = 2  # TODO(kevin): get this in a more principled way somehow?
         self._entity_type_decoder_embedding = Embedding(
-            self._num_entity_types, action_embedding_dim
+            num_embeddings=self._num_entity_types, embedding_dim=action_embedding_dim
         )
         self._decoder_num_layers = decoder_num_layers
 

diff --git a/allennlp_semparse/models/wikitables/wikitables_semantic_parser.py b/allennlp_semparse/models/wikitables/wikitables_semantic_parser.py
@@ -130,9 +130,11 @@ def __init__(
 
         self._num_entity_types = 5  # TODO(mattg): get this in a more principled way somehow?
         self._embedding_dim = question_embedder.get_output_dim()
-        self._entity_type_encoder_embedding = Embedding(self._num_entity_types, self._embedding_dim)
+        self._entity_type_encoder_embedding = Embedding(
+            num_embeddings=self._num_entity_types, embedding_dim=self._embedding_dim
+        )
         self._entity_type_decoder_embedding = Embedding(
-            self._num_entity_types, action_embedding_dim
+            num_embeddings=self._num_entity_types, embedding_dim=action_embedding_dim
         )
         self._neighbor_params = torch.nn.Linear(self._embedding_dim, self._embedding_dim)
 

diff --git a/requirements.txt b/requirements.txt
@@ -1,5 +1,5 @@
 # To be changed to allennlp>=1.0 once that's released.
-git+git://github.com/allenai/allennlp@28028a0544632307fe48e66a15a4b2a22c3dddda
+git+git://github.com/allenai/allennlp@fa14bd8c177a12709a2fac0616eafaa9ad430b0a
 
 # Used to create grammars for parsing SQL
 parsimonious>=0.8.0