Fix Issue: Languages text not visible on 'Emilia' theme #269 #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix for this issue #269 where the languages text is not visible in 'Emilia' theme.
Added fix for this issue #271 where Import CSV Alert Dialog test is not visible in 'Emilia' theme.
To contrast against the background colour for the language menu set by 'timelineBackgroundColor', I have aligned the text colour to use 'timelineBodyColor' from the the active theme for the language menu, instead of 'entryBodyColor'.
This involves an edit to CustomListPrefDialogFragCompat.kt
This also fixes the same text issue which is present in the First Day of the Week dialog (see screenshots).
I've added a second edit to address the issue with the Import CSV Alert Dialog, making changes to styles.xml where the AlertDialogTheme is set, again changing 'entryBodyColor' to 'timelineBodyColor' for the textColorPrimary and textColor Values, as well as the PositiveButtonStyle defined in the same section.
💚 How did you test it?
Manual test in Android Studio Emulator and on a Physical Pixel 6a.
Value comparison of the colour numbers set for 'entryBodyColor' and 'timelineBodyColor' in each theme in colors.xml.
The only theme affected other than Emilia, is Calm, which has very slightly different shades of text set by 'entryBodyColor' and 'timelineBodyColor'. See screenshots below.
📸 Screenshots / GIFs
Emilia Before:
Emilia After:
Calm Before:
Calm After:
Betsy Before (No Change):
Betsy After (No Change):
Emilia First Day of the Week, Before:
Emilia First Day of the Week, After:
Emilia Import Dialogue Before:
Emilia Import Dialogue After:
Calm Import Dialogue Before:
Calm Import Dialogue After:
Betsy Import Dialogue Before (No Change):
Betsy Import Dialogue After (No Change):