Fix vertical relative position in \D mode #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number register \n(.d does not contain the vertical position until wb is put into fmt. This is problematic for drawing functions because relative positions such as |1i are not relative to the current word buffer (in which the drawing is done) but to fmt. This causes unexpected drawings. This is not compliant to the behavior of either groff, heirloom doctools, or Plan 9's troff, but we the behavior with horizontal vertical position is already non-compliant. An alternative is to adopt the other troff's behavior, that is to never update the relative position while parsing a drawing function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number register \n(.d does not contain the
vertical position until wb is put into fmt. This
is problematic for drawing functions because
relative positions such as |1i are not relative to the current word buffer (in which the drawing is
done) but to fmt. This causes unexpected drawings.
This is not compliant to the behavior of either
groff, heirloom doctools, or Plan 9's troff, but
we the behavior with horizontal vertical position
is already non-compliant.
An alternative is to adopt the other troff's
behavior, that is to never update the relative
position while parsing a drawing function.