Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-1704: add nginx to the mesh #1396

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

TheOrangePuff
Copy link
Contributor

Description of the proposed changes

  • The mesh is currently missing access logs. The application layer logs are often unreliable too. By adding an nginx container that sits in front of the mesh we can ensure we are capturing access level logs.
  • We want to ensure this works as an in place upgrade for existing stacks. By passing a custom task definition we can still use the same load balancer and therefore upgrade without changing DNS records.'

Notes to reviewers

  • My nginx config skills are not the best so please let me know if anything needs changing there 🙏

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

}

http {
log_format json_combined escape=json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON logging threw me, but this seems correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it looks a bit funky in the config but it seems to work. We want to use JSON so we have better CloudWatch query support: https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/CWL_AnalyzeLogData-discoverable-fields.html

Copy link

@hubertott hubertott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ NGINX

@TheOrangePuff TheOrangePuff merged commit 4d77dc8 into main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants