Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore ending wildcards #1371

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

TheOrangePuff
Copy link
Contributor

Description of the proposed changes

  • Ignore wildcards at the end of from when routing from CDN to the BE.

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link

@hubertott hubertott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I am reading this right... you want to avoid a situation where by you have a remap id called SOMETHING.- ie. ends with a hyphen, because the input from path used a wildcard at the end... eg. SOMETHING.*

@TheOrangePuff
Copy link
Contributor Author

Just so I am reading this right... you want to avoid a situation where by you have a remap id called SOMETHING.- ie. ends with a hyphen, because the input from path used a wildcard at the end... eg. SOMETHING.*

@hubertott the current system only allows single files (e.g. test_robots.txt -> robots.txt). If we use a wildcard, we don't need the remap function to be there (and in fact, causes problems), a standard behaviour pointing to a different origin is fine.

@TheOrangePuff TheOrangePuff merged commit 677252f into main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants