DO-1652: Add name props, remove dependabot #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnholland
approved these changes
May 14, 2024
| @@ -119,6 +119,8 @@ export class PrerenderFargate extends Construct { | |||
|
|
|||
| const cluster = new ecs.Cluster(this, `${prerenderName}-cluster`, { | |||
| vpc: vpc, | |||
| clusterName: | |||
| props.clusterName !== undefined ? props.clusterName : undefined, | |||
There was a problem hiding this comment.
Might be better to have this as props.clusterName ? props.clusterName : undefined so that it equates null as false too along with the other ternaries.
feel free to ignore and merge
There was a problem hiding this comment.
I think that makes sense
Although all (most?) props define propName? so only assigning the actual type or undefined is possible
Keeping this for consistency's sake as most other things check explicitly for undefined but we should reconsider this in a future major version
TheOrangePuff
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes