Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-1557: disable checking CORS #1344

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

crispy101
Copy link
Contributor

@crispy101 crispy101 commented Apr 9, 2024

… to allow the custom x-prerender req header to go through

Description of the proposed changes

  • the custom x-prerender req header was causing "timed out" error as it is not in the Access-Control-Allow-Headers response header.
  • suppressing this security check on headless chrome to ignore the CORS header.
  • release 2.3.3

Screenshots (if applicable)

Other solutions considered (if any)

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@crispy101 crispy101 changed the title DO-1557: disable checking CORS to allow the custom x-prerender req he… DO-1557: disable checking CORS Apr 9, 2024
@crispy101 crispy101 merged commit 38a6dca into main Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants