Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core/ui] "Exposed" property added to attributeDesc #2528

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Just-Kiel
Copy link
Contributor

@Just-Kiel Just-Kiel commented Sep 10, 2024

Description

exposed is useful to display the attribute in the upper part of the node in the Graph Editor. Prior to this PR, all outputs attributes were displayed in that part, but only input File attributes were as well. Any other input attributes was displayed in the lower part of the node.

exposed is thus useless for output attributes, and is only taken into account for input attributes. By default, only File attributes are exposed while all the other attributes are not, in order to preserve the default behaviour we had until now.

@Just-Kiel Just-Kiel added the UI label Sep 10, 2024
@Just-Kiel Just-Kiel added this to the Meshroom 2024.1.0 milestone Sep 10, 2024
@Just-Kiel Just-Kiel self-assigned this Sep 10, 2024
Exposed is useful to display the attribute in the upper part of the node in the Graph Editor.
By default, File attributes are exposed.
@Just-Kiel Just-Kiel force-pushed the dev/exposingAttributesInGraphEditor branch from 8d01042 to da3335e Compare September 11, 2024 09:53
@fabiencastan
Copy link
Member

Need to expose "Features/Matches Folders" in AliceVision nodes.
It would be good to also expose "Describer Types".

@fabiencastan fabiencastan changed the title [core/ui] Exposed property added to attributeDesc [core/ui] "Exposed" property added to attributeDesc Sep 11, 2024
@fabiencastan fabiencastan merged commit e077e8c into develop Sep 11, 2024
4 checks passed
@fabiencastan fabiencastan deleted the dev/exposingAttributesInGraphEditor branch September 11, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants