Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make logging completely lazy
Alog used to create a lambda object to do the logging, and the lambda object support lazy evaluation of the parameters of the logging, but the creation of the lambda obj itself is not lazy.
This patch aims to make logging completely lazy, so that the cost of not logging is reduced to a simple
if
.For a function like this:
gcc will output:
Each logging statement generates only 3 instructions in the hot path: loading the log level from logger, test it, and make a conditional jump to actual logging code blocks (marked as
cold
), while it was compiled to many more instructions: