Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug when embedding regularizer is applied on empty list #486

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix a bug when embedding regularizer is applied on empty list #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions easy_rec/python/layers/input_layer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def get_plain_feature(self, features, group_name):
if is_embedding_column(col):
embedding_reg_lst.append(val)

if self._embedding_regularizer is not None:
if self._embedding_regularizer is not None and len(embedding_reg_lst) > 0:
regularizers.apply_regularization(
self._embedding_regularizer, weights_list=embedding_reg_lst)
return output_features, group_features
Expand Down Expand Up @@ -186,7 +186,7 @@ def get_sequence_feature(self, features, group_name):
seq_features.append((tmp_embedding, tmp_seq_len))
embedding_reg_lst.append(tmp_embedding)

if self._embedding_regularizer is not None:
if self._embedding_regularizer is not None and len(embedding_reg_lst) > 0:
regularizers.apply_regularization(
self._embedding_regularizer, weights_list=embedding_reg_lst)
return seq_features
Expand Down
Loading