Adding method to verify signature on SignedTransaction object #308

barnjamin · 2022-03-25T11:43:10Z

I can do this across SDKs if this is reasonable

Should fill the need of algorand-devrel/community#10

API is

#...
pk, sk = get_account()
pay_txn = transaction.PaymentTxn(pk, sp, rcv, 10000)
stxn = pay_txn.sign(sk)
if not stxn.verify_signature():
    print("failzore")
#...

algochoi

I was just wondering why this API has different parameters from the existing verify methods. I don't have a strong opinion on this, but I'm also curious on the naming (opposed to raw_verify or something suggested on the original ticket.

algochoi · 2022-03-25T15:48:39Z

algosdk/future/transaction.py

@@ -2145,6 +2145,35 @@ def get_txid(self):
        """
        return self.transaction.get_txid()

+    def verify_signature(self):
+        """
+        Verify the signature on the transaction is valid


Suggested change

Verify the signature on the transaction is valid

Verify that the signature on the transaction is valid.

algochoi · 2022-03-25T16:32:56Z

algosdk/future/transaction.py

+                prefixed_message, base64.b64decode(self.signature)
+            )
+            return True
+        except BadSignatureError:


I think nacl's VerifyKey API can now return a TypeError or ValueError. The multisig/logicsig verify in the Python SDK doesn't catch these errors yet either so I think it would be nice to update them :D

barnjamin requested review from algochoi and jasonpaulos March 25, 2022 11:45

adding verify sig on SignedTransaction object

1089ece

barnjamin requested a review from winder March 25, 2022 11:53

algochoi reviewed Mar 25, 2022

View reviewed changes

barnjamin closed this Mar 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding method to verify signature on SignedTransaction object #308

Adding method to verify signature on SignedTransaction object #308

barnjamin commented Mar 25, 2022 •

edited

Loading

algochoi left a comment

algochoi Mar 25, 2022

algochoi Mar 25, 2022

	Verify the signature on the transaction is valid
	Verify that the signature on the transaction is valid.

Adding method to verify signature on SignedTransaction object #308

Adding method to verify signature on SignedTransaction object #308

Conversation

barnjamin commented Mar 25, 2022 • edited Loading

algochoi left a comment

Choose a reason for hiding this comment

algochoi Mar 25, 2022

Choose a reason for hiding this comment

algochoi Mar 25, 2022

Choose a reason for hiding this comment

barnjamin commented Mar 25, 2022 •

edited

Loading