Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BodyWithConfig::into_reader -> reader #845

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

algesten
Copy link
Owner

BodyWithConfig::into_reader is not a good name, because even though it converts the builder BodyWithConfig into a reader, the user is probably considering the ownership of Body, not the builder. Whether the Body is owned or shared depends on how we got the BodyWithConfig, hence it makes sense to just finish with .reader() for both owned and shared situation.

@algesten algesten merged commit 19132bf into main Oct 11, 2024
66 checks passed
@algesten algesten deleted the fix/into-reader branch October 11, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants