new feature flag to control whether or not to detect proxy settings from environment by default #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o detect proxy settings from environment by default
algesten
requested changes
Nov 22, 2023
src/agent.rs
Outdated
| /// The default is `false`, i.e. not detecting proxy from env since this is | ||
| /// a potential security risk. | ||
| /// The default is `false` without the `proxy-from-env` feature flag, i.e. | ||
| /// not detecting proxy from env, to maintain backward compatibility. |
There was a problem hiding this comment.
Having automatic proxy detection is a security risk. I want you to rephrase this doc to keep the warning.
…e `proxy-from-env` feature flag
toymil
force-pushed
the
proxy_from_env_feature_flag
branch
from
daf99ad
to
d9bbb45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of many libs and tools is to pick up proxy environment variables. Being able to config
ureqto behave the same way makes implementing this behavior in other software easier.If the default is
falseand we have no ways to make it default totrue, implementing this behavior in other software would mean one of the following:ureq::get(..), because we need to construct anAgentBuilderand calltry_proxy_from_env, thenbuild, every time.Agent, use that throughout the code.