Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every other week someone comes to us and ask why we don’t stick to SI units. Sure, no one remembers which is supposed to be babbage, but what’s the deal with Kwei with a uppercase K, kilo doesn’t start with uppercase! Why are unit names written in full but prefixes just the letter? It’s not Mbyte or mliter, it’s either the Megabyte or the ml. And grand, really? It’s not a SI unit it’s a number.
I always say that unit names are just suggestions and we should only use ether and wei, but in practice that doesn’t work.
Most things are in ether. Gas prices are usually in finney or szabo. Basic functions are in wei.
Then it dawns on me that the only that actually matter are ether, finney and szabo, and they have a direct 1000 relationship. Here’s a nice mnemonic: they’re the micro and the mili. A Finney is a mili-ether, szabo is the micro-ether. Ether, mili, micro. Now I usually don’t memorize the micro but since I’m having to remember the szabo anyway, why not the micro-?
So I did some cosmetic changes, made the comments clearer on this, and added support for SI prefixes femto-, pico-, nano-, micro- and mili-
Just giving developers more choice, since so many of them asked for this